Add dummy feature #71
Conversation
newpavlov
force-pushed
the
dummy_feature
branch
from
54bb8d7
to
c7ab9c3
Compare
|
@josephlr |
src/lib.rs
Outdated
| @@ -225,18 +227,30 @@ cfg_if! { | |||
| target_env = "sgx", | |||
| )))] { | |||
| #[path = "rdrand.rs"] mod imp; | |||
| } else if #[cfg(target_arch = "wasm32")] { | |||
| // ideally we would like to use `target = "wasm32-unknown-unknown"`, | |||
There was a problem hiding this comment.
Personally I find something like:
...
} else if #[cfg(all(target_arch = "wasm32", feature = "wasm-bindgen"))] {
#[path = "wasm32_bindgen.rs"] mod imp;
} else if #[cfg(all(target_arch = "wasm32", feature = "stdweb"))] {
#[path = "wasm32_stdweb.rs"] mod imp;
} else if #[cfg(feature = "dummy")] {
#[path = "dummy.rs"] mod imp;
} else {
compile_error!("\
...to be a little more readable. It avoids nested cfg_if!s, and we don't need the unknown specifier. If we get here, the other wasm32 cases are taken care of.
In theory, a new wasm32 target could be added that's not addressed in the above, but having the stdweb/wasm-bindgen features work in that case seems fine (even ideal).
There was a problem hiding this comment.
I am not sure about not needing the unknown specifier. Imagine that we don't have WASI or Emscripten and they will be added in future, with this config even if getrandom will work on them, I wouldn't call it a correct target support. But I guess since we can't use target_vendor here, we are not completely future proof anyway, so it makes sense to simplify the code.
Closes #49
Strictly speaking it may be considered a breaking change. We could make
dummyfeature enabled-by-default, but I am not sure if we should.