Skip to content

Pin the cross binary to avoid CI flakiness #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 25, 2020
Merged

Pin the cross binary to avoid CI flakiness #147

merged 1 commit into from
May 25, 2020

Conversation

josephlr
Copy link
Member

Signed-off-by: Joe Richey joerichey@google.com

@josephlr
ci: Pin the Cross binary to avoid breaking the CI
3ae41eb 
Signed-off-by: Joe Richey <joerichey@google.com>
@josephlr josephlr changed the title WIP: Fix CI Pin the cross binary to avoid CI flakiness May 23, 2020
@josephlr josephlr requested a review from dhardy May 23, 2020 00:40
@josephlr
Copy link
Member Author

@dhardy this is ready to merge and should fix some if the flakiness I saw in #146

@josephlr josephlr requested a review from newpavlov May 23, 2020 00:41
@dhardy
Copy link
Member

dhardy commented May 25, 2020

Both the Linux runners seem to be happy.

Any idea what happened to AppVeyor? It hasn't run in a month.

@josephlr
Copy link
Member Author

Both the Linux runners seem to be happy.

It's weird, I saw cross related failures here, but then I re-ran things and everything worked. I think the issue was causes by some things getting out of sync right when a new version of cross was released. Regardless, pinning should prevent this sort of thing.

Any idea what happened to AppVeyor? It hasn't run in a month.

I'll see what happens when I merge this PR, maybe it's only running on master?

@josephlr josephlr merged commit 7631f75 into rust-random:0.2 May 25, 2020
@josephlr josephlr deleted the ci branch May 25, 2020 10:01
@josephlr
Copy link
Member Author

Any idea what happened to AppVeyor? It hasn't run in a month.

I'll see what happens when I merge this PR, maybe it's only running on master?

It looks like AppVeyor just wasn't running on the 0.2 branch, #148 fixes that issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhardy dhardy dhardy approved these changes

@newpavlov newpavlov Awaiting requested review from newpavlov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josephlr @dhardy