Improve src/lib.rs cfgs #119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now for each of `util_libc` and `use_file` we have a list of `target_os` configs to determine if we build the module. This PR moves these mod declarations into the main `cfg_if` statement (the one that selects which implementation we use). This way, the mod statements are kept in-sync with the implementations that use them. Also, I merged together `target_os` cfgs that have the same implementation. The downside to this is that the targets are no longer in alphabetical order. Also, this is only being applied to `0.2` as the `0.1` cfgs still have to keep `std` around.
newpavlov
approved these changes
Oct 24, 2019
Well, to be fair the main idea is yours. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested by @newpavlov here: #116 (comment)
Right now for each of
util_libcanduse_filewe have a list oftarget_osconfigs to determine if we build the module.This PR moves these mod declarations into the main
cfg_ifstatement(the one that selects which implementation we use). This way, the mod
statements are kept in-sync with the implementations that use them.
Also, I merged together
target_oscfgs that have the sameimplementation. The downside to this is that the targets are no longer
in alphabetical order.
Also, this is only being applied to
0.2as the0.1cfgs still haveto keep
stdaround.