Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix data layout in custom target used for testing #454

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

phil-opp
Copy link
Member

@phil-opp phil-opp commented Feb 2, 2024

Fixes the test errors on CI.

Copy link
Member

@Freax13 Freax13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

Out of curiosity, do you happen to know why the "p270:32:32..." specs are necessary? If my understanding of https://llvm.org/docs/LangRef.html#data-layout is correct, they specify 32-bit address spaces, and it's not immediately obvious to me what that's useful for.

@phil-opp
Copy link
Member Author

phil-opp commented Feb 2, 2024

I don't know why/if this part is necessary, but the Rust compiler enforces since rust-lang/rust#120062 that the data-layout matches the layout of the LLVM target exactly.

@phil-opp phil-opp merged commit 3eb9c22 into master Feb 2, 2024
12 checks passed
@phil-opp phil-opp deleted the fix-data-layout branch February 2, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants