uefi: find_handles() and locate_handle() can return empty collection + doc improvements #1855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`uefi` is supposed to provide convenient and idiomatic high-level abstractions. Currently, `find_handles()` and `locate_handle()` can never return `&[]` respectively `Vec::new()` as an empty response from the underlying UEFI boot service is always treated as Error originating from `Status::NOT_FOUND`. We should not expose that UEFI implementation details to users. It is more convenient for users to just check if the resulting slice/vector is empty or not.
phip1611
force-pushed
the
find-handles
branch
2 times, most recently
from
c0ef184 to
8b3fc1d
Compare
Member
|
Left some design thoughts in the issue: #1854 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uefiis supposed to provide convenient and idiomatic high-levelabstractions. Currently,
find_handles()andlocate_handle()cannever return
&[]respectivelyVec::new()as an empty responsefrom the underlying UEFI boot service is always treated as Error
originating from
Status::NOT_FOUND.We should not expose that UEFI implementation details to users. It is
more convenient for users to just check if the resulting slice/vector
is empty or not.
Closes #1854
Steps to Undraft
Checklist