uefi: use core::net-types in public API + remove duplications #1780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // NOTE: We cannot impl From<IpAddress> for core::net::IpAddr | ||
| // because IpAddress is a raw union, with nothing indicating | ||
| // whether it should be considered v4 or v6. | ||
| pub use uefi_raw::{IpAddress as EfiIpAddr, MacAddress as EfiMacAddr}; |
There was a problem hiding this comment.
I'm unsure about this, is there value to exposing the raw types if the rest of the public API just used the core::net types? Folks who do need to drop down to the lower-level API can always depend on uefi-raw directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the final step of #1575, after many pre-requisites have been merged recently.
Closes #1575
Checklist