Make InformationBuilder adhere the API guidelines. #162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The API guidelines state that methods of builders should return `self` to allow chaining. Add missing documentation strings to builder functions.
phip1611
reviewed
Jun 29, 2023
phip1611
requested changes
Jun 29, 2023
Member
phip1611
left a comment
phip1611
left a comment
There was a problem hiding this comment.
Please add a changelog entry
You can create a new
## Unreleased
- foo
section in the changelog.
Author
I added the respective changelog entry. Because the changes made it necessary to modify the tests, I think this qualifies as a breaking change. |
phip1611
approved these changes
Jun 29, 2023
Member
|
Please fix the integration test |
Because the builder's methods now consume it, the integration test failed. The MBI can now be produced directly by chaining them.
phip1611
approved these changes
Jun 29, 2023
Member
|
Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rust API guidelines state that methods of builders should return
selfto allow chaining.Add missing documentation strings to builder functions.