Skip to content

Multiboot2: More Safety for Getters of Strings from Tags (Prepare Release v0.14.0) #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 30, 2022
Merged

Multiboot2: More Safety for Getters of Strings from Tags (Prepare Release v0.14.0) #115

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
361449c
multiboot2: more safety for tags that hold an str
phip1611 Jun 19, 2022
fd0cfd2
multiboot2: tests for parsing strings from tags
phip1611 Jun 30, 2022
4885ccb
multiboot2: more safety for strings from rsdp
phip1611 Jun 19, 2022
c67069a
multiboot2: latest cargo clippy improvements
phip1611 Jun 19, 2022
417689b
multiboot2: prepare v0.14.0
phip1611 Jun 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
multiboot2: latest cargo clippy improvements
  • Loading branch information
@phip1611
phip1611 committed Jun 30, 2022
commit c67069abb30bd73373ed444830976ac66d873b47
8 changes: 4 additions & 4 deletions multiboot2/src/framebuffer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ use crate::Reader;
use core::slice;

/// The VBE Framebuffer information Tag.
#[derive(Debug, PartialEq)]
#[derive(Debug, PartialEq, Eq)]
pub struct FramebufferTag<'a> {
/// Contains framebuffer physical address.
///
Expand All @@ -29,7 +29,7 @@ pub struct FramebufferTag<'a> {
}

/// The type of framebuffer.
#[derive(Debug, PartialEq)]
#[derive(Debug, PartialEq, Eq)]
pub enum FramebufferType<'a> {
/// Indexed color.
Indexed {
Expand All @@ -55,7 +55,7 @@ pub enum FramebufferType<'a> {
}

/// An RGB color type field.
#[derive(Debug, PartialEq)]
#[derive(Debug, PartialEq, Eq)]
pub struct FramebufferField {
/// Color field position.
pub position: u8,
Expand All @@ -65,7 +65,7 @@ pub struct FramebufferField {
}

/// A framebuffer color descriptor in the palette.
#[derive(Clone, Copy, Debug, PartialEq)]
#[derive(Clone, Copy, Debug, PartialEq, Eq)]
#[repr(C, packed)] // only repr(C) would add unwanted padding at the end
pub struct FramebufferColor {
/// The Red component of the color.
Expand Down
4 changes: 2 additions & 2 deletions multiboot2/src/vbe_info.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ impl fmt::Debug for VBEModeInfo {
/// A VBE colour field.
///
/// Descirbes the size and position of some colour capability.
#[derive(Debug, PartialEq, Copy, Clone)]
#[derive(Debug, PartialEq, Eq, Copy, Clone)]
#[repr(C, packed)]
pub struct VBEField {
/// The size, in bits, of the color components of a direct color pixel.
Expand Down Expand Up @@ -327,7 +327,7 @@ bitflags! {
}

/// The MemoryModel field specifies the general type of memory organization used in modes.
#[derive(Debug, PartialEq, Copy, Clone)]
#[derive(Debug, PartialEq, Eq, Copy, Clone)]
#[repr(u8)]
#[allow(missing_docs)]
pub enum VBEMemoryModel {
Expand Down