Make bootsector a staticlib #113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katietheqt-old
approved these changes
Apr 29, 2020
It doesn't apply to e.g. the test-kernel.
phil-opp
force-pushed
the
make-bootsector-a-staticlib
branch
from
56fbd81 to
c03a683
Compare
phil-opp
force-pushed
the
make-bootsector-a-staticlib
branch
from
c03a683 to
0630857
Compare
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Apr 29, 2020
113: Make bootsector a staticlib r=rybot666 a=phil-opp Makes the bootsector self-contained by making it a staticlib. This ensures that we don't accidentally use functions from stage_2. The `stage_2` crate is now the main executable, which links the bootsector through a build script. Co-authored-by: Philipp Oppermann <dev@phil-opp.com>
|
Timed out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the bootsector self-contained by making it a staticlib. This ensures that we don't accidentally use functions from stage_2.
The
stage_2crate is now the main executable, which links the bootsector through a build script.