Add is_one. #39
Merged
Add is_one. #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cuviper
reviewed
Feb 22, 2018
src/identities.rs
Outdated
| /// Returns `true` if `self` is equal to the multiplicative identity. | ||
| /// | ||
| /// Compatibility note: this method will be a requirement to implement in the future; new | ||
| /// implementors should provide it for future-compatibility. |
There was a problem hiding this comment.
I'm a little hesitant about this scary-sounding note, because we're definitely not going to change that without a semver bump! And when we do, it should also drop the Self: PartialEq, which means they'll have porting work to do anyway. Maybe instead just advise that implementations should consider adding it now for better performance, noting that it will only become required in a future breaking change.
Also, let's put #[inline] on this.
|
Applied your suggestions; is the caveat better now? |
|
Works for me, thanks! bors r+ |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the version recommended in #5. That issue should remain open to track the breaking-change version.