Skip to content

Deprecate Rational #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 5, 2021
Merged

Deprecate Rational #92

merged 3 commits into from
Mar 5, 2021

Conversation

vks
Copy link
Contributor

@vks vks commented Feb 10, 2021

Fixes #89.

@vks
Copy link
Contributor Author

vks commented Feb 10, 2021

I changed the tests to use Rational64 instead of Rational.

@cuviper
Copy link
Member

cuviper commented Mar 5, 2021

Thanks! I added a deprecation note and marked it since 0.4.0.
(It's not strictly a breaking change, but I'm about to make a bump for num-bigint anyway.)

bors r+

@bors
Copy link
Contributor

bors bot commented Mar 5, 2021

Build succeeded:

@bors bors bot merged commit 9af254a into rust-num:master Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename Rational -> RationalSize
2 participants
@vks @cuviper