Implement Pow #21
Merged
Implement Pow #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixed compile errors; this only increases compile time by .1s on my box so I think this is fine. |
vks
reviewed
Apr 10, 2018
src/lib.rs
Outdated
| Pow::pow(self.clone(), expon) | ||
| } | ||
| } | ||
| impl<'a, T: Clone + Integer + Pow<$unsigned, Output = T>> Pow<&'a $exp> for Ratio<T> { |
There was a problem hiding this comment.
This does not need Clone, does it?
There was a problem hiding this comment.
Everything requires Clone, even Ratio::new. I'd prefer to keep it for now. We could someday relax this without it being a breaking change, but not the other way.
|
This looks good, however it would be nice to have some tests. |
|
Updated the existing bors r+ |
Build failed |
|
Travis timeout without even starting our job. bors r+ |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be merged after #19, as this PR depends on that one. Fixes #20.
Will need to investigate compile time increases that this change causes.