Add support for bytemuck traits
#100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`bytemuck` seems to be the *de facto* standard crate for safe transmuting. Because `Complex<T>` is `repr(C)`, it would satisfy the requirements for `Zeroable` and `Pod`, as long as `T` satisfies them as well. Add optional implemenations of `Zeroable` and `Pod`, gated behind the `bytemuck` feature.
|
@cuviper or anyone else, would you have a second to take a look at this? |
|
Can you add the feature to |
|
@cuviper, done |
|
Pinging this again. I think it's ready. |
|
Another bump. @cuviper? |
cuviper
reviewed
Apr 26, 2022
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bytemuckseems to be the de facto standard crate for safetransmuting. Because
Complex<T>isrepr(C), it would satisfy therequirements for
ZeroableandPod, as long asTsatisfies them aswell.
Add optional implemenations of
ZeroableandPod, gated behind thebytemuckfeature.Closes #99