Merge #25

25: Use direct ops in Rem<T> for Complex<T> r=cuviper a=cuviper

This avoids overflow issues with dividing by `norm_sqr`, and is
probably faster too, just for being simpler.

Co-authored-by: Josh Stone <cuviper@gmail.com>

src/lib.rs

@@ -849,7 +849,7 @@ impl<T: Clone + Num> Rem<T> for Complex<T> {
 
     #[inline]
     fn rem(self, other: T) -> Complex<T> {
-        self % Complex::new(other, T::zero())
+        Complex::new(self.re % other.clone(), self.im % other)
     }
 }
 
@@ -1821,6 +1821,14 @@ mod test {
 			assert_eq!(_neg1_1i % 2.0, _neg1_1i);
 			assert_eq!(-_4_2i % 3.0, Complex::new(-1.0, -2.0));
         }
+
+        #[test]
+        fn test_div_rem_gaussian() {
+            // These would overflow with `norm_sqr` division.
+            let max = Complex::new(255u8, 255u8);
+            assert_eq!(max / 200, Complex::new(1, 1));
+            assert_eq!(max % 200, Complex::new(55, 55));
+        }
     }
 
     #[test]