Add function on RouteMessageBuilder for setting route MTU#126
Open
MarkusPettersson98 wants to merge 1 commit intorust-netlink:mainfrom
Open
Add function on RouteMessageBuilder for setting route MTU#126MarkusPettersson98 wants to merge 1 commit intorust-netlink:mainfrom
MarkusPettersson98 wants to merge 1 commit intorust-netlink:mainfrom
Conversation
cathay4t
requested changes
Oct 29, 2025
| pub fn mtu(mut self, mtu: u32) -> Self { | ||
| self.message | ||
| .attributes | ||
| .push(RouteAttribute::Metrics(vec![RouteMetric::Mtu(mtu)])); |
Member
There was a problem hiding this comment.
This override future changes to other RouteMetric (e.g. cwnd).
Please create similar stuff like RouteNextHopBuilder
Contributor
Author
There was a problem hiding this comment.
Sorry, I don't quite understand the solution you are suggestion. Should I create something like a RouteMetricsBuilder inspired by RouteNextHopBuilder?
Member
There was a problem hiding this comment.
Yes. RouteMetricsBuilder is required. Otherwise, it is impossible to configure both cwnd and mtu.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title. Found myself doing the following thing in my code:
With this patch, I would not need to create a mutable
RouteMessage:)