-
Notifications
You must be signed in to change notification settings - Fork 62
Re #21 - Add matchall filter type #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks, |
Codecov Report
@@ Coverage Diff @@
## main #22 +/- ##
==========================================
+ Coverage 45.83% 46.13% +0.29%
==========================================
Files 73 73
Lines 5969 5931 -38
==========================================
Hits 2736 2736
+ Misses 3233 3195 -38
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
68a956d
to
bcddc75
Compare
Hi, I've rebased and fixed the formatting errors, will pay attention to the next CI run for additonal issues. |
@cathay4t Do you have any comments? |
src/rtnl/tc/constants.rs
Outdated
pub const TCA_MATCHALL_PAD: u16 = 5; | ||
pub const TCA_MATCHALL_MAX: u16 = TCA_MATCHALL_PAD; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove TCA_MATCHALL_PAD
and TCA_MATCHALL_MAX
. They are not used in this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed them. In the same file, TCA_MIRRED_PAD and TCA_MIRRED_MAX follow the same pattern, should those be removed too? (I can make a separate PR to do that).
This tc filter matches all packets that encounter it. Signed-off-by: Erich Heine <erich@cloudflare.com>
Signed-off-by: Erich Heine <erich@cloudflare.com>
53a07e6
to
cb90699
Compare
@sophacles Thanks for the patch. I have amended the patch to hold |
This tc filter matches all packets that encounter it.