Skip to content

Re #21 - Add matchall filter type #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 14, 2023

Conversation

sophacles
Copy link

This tc filter matches all packets that encounter it.

@wllenyj
Copy link
Contributor

wllenyj commented Feb 16, 2023

Thanks,
Please fix the ci fail.

@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Merging #22 (bcddc75) into main (62d2411) will increase coverage by 0.29%.
The diff coverage is 0.00%.

❗ Current head bcddc75 differs from pull request most recent head cb90699. Consider uploading reports for the commit cb90699 to get more accurate results

@@            Coverage Diff             @@
##             main      #22      +/-   ##
==========================================
+ Coverage   45.83%   46.13%   +0.29%     
==========================================
  Files          73       73              
  Lines        5969     5931      -38     
==========================================
  Hits         2736     2736              
+ Misses       3233     3195      -38     
Impacted Files Coverage Δ
src/rtnl/tc/nlas/filter/matchall.rs 0.00% <0.00%> (ø)
src/rtnl/tc/nlas/options.rs 62.85% <0.00%> (-13.01%) ⬇️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sophacles
Copy link
Author

Hi, I've rebased and fixed the formatting errors, will pay attention to the next CI run for additonal issues.

@wllenyj
Copy link
Contributor

wllenyj commented Feb 21, 2023

@cathay4t Do you have any comments?

Comment on lines 29 to 30
pub const TCA_MATCHALL_PAD: u16 = 5;
pub const TCA_MATCHALL_MAX: u16 = TCA_MATCHALL_PAD;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove TCA_MATCHALL_PAD and TCA_MATCHALL_MAX. They are not used in this PR

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed them. In the same file, TCA_MIRRED_PAD and TCA_MIRRED_MAX follow the same pattern, should those be removed too? (I can make a separate PR to do that).

@cathay4t cathay4t added the Wait_Submitter PR reviewed with change requests label Mar 26, 2023
Erich Heine added 2 commits April 14, 2023 16:24
This tc filter matches all packets that encounter it.

Signed-off-by: Erich Heine <erich@cloudflare.com>
Signed-off-by: Erich Heine <erich@cloudflare.com>
@cathay4t
Copy link
Member

@sophacles Thanks for the patch. I have amended the patch to hold Signed-off-by: in git commit message. Next time, please use git commit --signoff.

@cathay4t cathay4t merged commit 36fad93 into rust-netlink:main Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Wait_Submitter PR reviewed with change requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants