Re #19 - Add the nat action to tc

[sophacles]

No description provided.

[wllenyj]

Please rebase, and solve the ci failure.

[codecov]

Codecov Report

Merging #20 (5fecd0d) into main (75ce74c) will decrease coverage by 0.70%.
The diff coverage is 0.00%.

❗ Current head 5fecd0d differs from pull request most recent head 32744b0. Consider uploading reports for the commit 32744b0 to get more accurate results

@@            Coverage Diff             @@
##             main      #20      +/-   ##
==========================================
- Coverage   46.53%   45.83%   -0.70%     
==========================================
  Files          72       73       +1     
  Lines        5880     5969      +89     
==========================================
  Hits         2736     2736              
- Misses       3144     3233      +89     

Impacted Files	Coverage Δ
src/rtnl/tc/nlas/action/mod.rs	60.56% <0.00%> (-2.22%)	⬇️
src/rtnl/tc/nlas/action/nat.rs	0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[sophacles]

Thanks for taking a look @wllenyj . I've rebased and fixed the formatting errors reported by CI. Will pay attention for additional failures in case I missed something.

[wllenyj]

@cathay4t Do you have any comments?

[sophacles]

Please note, I added a builder method to the TcNat struct to set the egress bit for NAT direction.

[cathay4t]

I have ammend the git commit message to include Signed-off-by: Erich Heine <....>.

[cathay4t]

Besides removing TCA_NAT_MAX and PAD, looks good to me.

I am not TC expert, I trust you know your territory

[cathay4t]

Please remove TCA_NAT_PAD and TCA_NAT_MAX.
The TCA_NAT_PAD is unused anywhere. The TCA_NAT_MAX is not constant to kernel but a internal variable might change in future release of linux kernel.

[cathay4t]

This has been delayed for a long time. Let me amend the patch by removing TCA_NAT_MAX and PAD.

amended

[sophacles]

This has been delayed for a long time. Let me amend the patch by removing TCA_NAT_MAX and PAD.

Apoligies, I lost track of that request. Thank you for taking care of it!