fix: parse AUDIT_REPLACE properly #14
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The AUDIT_REPLACE message payload is a uint32 number, which is not an ascii string. This causes parsing issues when such a message is parsed. There is two solutions for this afaict: - Parse the AUDIT_REPLACE message on its own, making minimal changes. - Change the AuditMessage Event/Other enums to store a Vec<u8> instead of a String. I picked the first one, to have minimal impact on existing code. However, the second solution imho would be a much better solution. This crate should not expect every message to a utf-8, which is a weird assumption. Its much better to let the caller decide how to parse the payloads, and not have errors when messages have non utf-8 compatible bytes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AUDIT_REPLACE message payload is a uint32 number, which is not an ascii string. This causes parsing issues when such a message is parsed, and one of the byte is >= 0x7F
There is two solutions for this afaict:
I picked the first one, to have minimal impact on existing code. However, the second solution imho would be a much better solution. This crate should not expect every message to a utf-8, which is a weird assumption. Its much better to let the caller decide how to parse the payloads, and not have errors when messages have non utf-8 compatible bytes.