Add logspace constructor#617
Add logspace constructor#617LukeMathWalker merged 5 commits intorust-ndarray:masterfrom JP-Ellis:logspace
logspace constructor#617Conversation
Signed-off-by: JP-Ellis <josh@jpellis.me>
|
Thanks for working on this @JP-Ellis! To move this forward it would be nice to have tests for these new functions, testing both happy and unhappy paths 👍 |
Signed-off-by: JP-Ellis <josh@jpellis.me>
|
@LukeMathWalker All done, I have added tests within a |
Signed-off-by: JP-Ellis <josh@jpellis.me>
Signed-off-by: JP-Ellis <josh@jpellis.me>
|
I haven't had a chance to review this in detail, but at first glance, I had a couple of thoughts:
|
If we decide to keep compatibility with their naming convention, then I'd advice to add a
I have the same gut feeling that |
Signed-off-by: JP-Ellis <josh@jpellis.me>
|
Great, so I've renamed the Additionally, I've changed the way each step is calculated to avoid a possible small error from accumulating. Before merging this, I would recommend that this pull request be squashed into one commit. |
|
It looks good to me - happy to squash and merge 🚀 |
This pull requests adds the
logspaceconstructor for Array1 that works in the same way aslinspacebut creates logarithmically spaced floats.This implementation supports both positive and negative intervals, though
(obviously) not intervals which cross
0.0.