ndk: Replace posix module with std::io::Error::from_raw_os_error
#291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
Platform specific - i.e. POSIX - error codes can be wrapped in humand readable form by Rust's `std` through [`Error::from_raw_os_error()`]. Certain NDK interfaces use these codes directly from `errno.h` through [`Errors.h`]. [`Error::from_raw_os_error()`]: https://doc.rust-lang.org/std/io/struct.Error.html#method.from_raw_os_error [`Errors.h`]: https://cs.android.com/android/platform/superproject/+/master:system/core/libutils/include/utils/Errors.h
MarijnS95
force-pushed
the
posix-io-error
branch
from
ad4be4e to
94a1400
Compare
MarijnS95
added
blocking a release
Contributor
|
Awesome! Much cleaner now 😍 |
msiglreith
approved these changes
Jun 11, 2022
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platform specific - i.e. POSIX - error codes can be wrapped in humand readable form by Rust's
stdthroughError::from_raw_os_error(). Certain NDK interfaces use these codes directly fromerrno.hthroughErrors.h.