ndk-build,cargo-apk: Disable aapt compression for the dev profile
#283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarijnS95
force-pushed
the
dev-no-aapt-compression
branch
2 times, most recently
from
1d69dd6 to
a89e20e
Compare
Closed
MarijnS95
force-pushed
the
dev-no-aapt-compression
branch
2 times, most recently
from
8a30fbf to
f1121c0
Compare
msiglreith
approved these changes
Jun 10, 2022
MarijnS95
force-pushed
the
dev-no-aapt-compression
branch
2 times, most recently
from
9eb745e to
fd63485
Compare
Compressing multi-megabyte libraries in `aapt` is a singlethreaded process that takes many (tens of) seconds, for no apparent gain. It slows down the iterative development process significantly whereas there's no concern for `adb` transferring larger `apk`s over even USB 2.0 (which is still much faster than the bandwidth `aapt` provides for compression) nor typically any space constraints on development devices. The `-0` option disables compression for all files with a given extension, or all files when the argument is an empty string (`""`).
MarijnS95
force-pushed
the
dev-no-aapt-compression
branch
from
fd63485 to
2e22314
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in #153:
Compressing multi-megabyte libraries in
aaptis a singlethreaded process that takes many (tens of) seconds, for no apparent gain. It slows down the iterative development process significantly whereas there's no concern foradbtransferring largerapks over even USB 2.0 (which is still much faster than the bandwidthaaptprovides for compression) nor typically any space constraints on development devices.