Skip to content

native-activity: Check for null saved_state_in pointer #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 26, 2024
Merged

native-activity: Check for null saved_state_in pointer #157

merged 1 commit into from
Apr 26, 2024

Conversation

@rib
Copy link
Member

@rib rib commented Apr 26, 2024

Avoids calling std::slice::from_raw_parts with a null saved_state_in pointer.

Fixes: #153

@skibon02 @rib
native-activity: Check for null saved_state_in pointer
1480c2e 
Avoids calling `std::slice::from_raw_parts` with a null `saved_state_in`
pointer.

Fixes: #153
@rib rib requested a review from MarijnS95 April 26, 2024 15:23
@rib
Copy link
Member Author

rib commented Apr 26, 2024

I opened up a new PR since I wasn't able to push to the branch for #154

The commit should still attribute @skibon02 for the fix (thanks!)

@rib rib merged commit 7bd3ba6 into main Apr 26, 2024
@rib rib deleted the rib/pr/null-saved-state-ptr-check branch April 26, 2024 15:37
@rib rib mentioned this pull request Apr 26, 2024
Closed
@MarijnS95 MarijnS95 mentioned this pull request Jul 9, 2024
Closed
@0x53A 0x53A mentioned this pull request Apr 25, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MarijnS95 MarijnS95 Awaiting requested review from MarijnS95

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

panic on nightly: from_raw_parts safety contract violation

3 participants

@rib @skibon02