Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump MSRV to 1.68 #123

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Bump MSRV to 1.68 #123

merged 1 commit into from
Sep 25, 2023

Conversation

rib
Copy link
Collaborator

@rib rib commented Sep 25, 2023

This is a redo of #103 now that Winit has updated its CI to not build its Android backend against its strict MSRV, primarily aimed at supporting Debian on Linux.

  • Lets us build with cargo ndk 3+
  • Lets us remove suppression for false-negative clippy warning about unsafe blocks in unsafe functions

1.68.0 notably builds the standard library with a newer r25 NDK toolchain which avoid the need for awkward libgcc workarounds, so it's anyway a desirable baseline for Android projects.

- Lets us build with cargo ndk 3+
- Lets us remove suppression for false-negative clippy warning about unsafe
  blocks in unsafe functions

- 1.68.0 notably also builds the standard library with a newer r25 NDK
  toolchain which avoid the need for awkward libgcc workarounds, so it's
  anyway a desirable baseline for Android projects.
@rib rib merged commit 83cdb56 into main Sep 25, 2023
3 checks passed
@MarijnS95 MarijnS95 deleted the rib/pr/msrv-1.68-v2 branch October 4, 2023 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant