Skip to content

Add sponsors page #951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 20, 2019
Merged

Add sponsors page #951

merged 1 commit into from
Nov 20, 2019

Conversation

carols10cents
Copy link
Member

@carols10cents carols10cents commented Nov 13, 2019

This adds a section to the bottom of the homepage for thanks in general, with links to thanks.rust-lang.org and a new sponsors page:

new homepage section

The new sponsors page thanks Microsoft, AWS, and Mozilla for their infrastructure sponsorships (in 2 screenshots, there isn't actually a blank spot on the page between Microsoft and AWS):

new sponsors page part 1

new sponsors page part 2

I took most of the text from the 1.37.0 release announcement.

Before merging this, I would like review on the text and logo inclusion from:

I'm happy to make any modifications; let me know what needs to change. Thanks!

@skade
Copy link
Contributor

skade commented Nov 13, 2019

I think the approach of putting a thanks on the homepage is a very clever one, thanks!

I'll review later to get it out of the door.

@pietroalbini
Copy link
Member

cc @davidbarsky for the AWS side.

By the way, maybe the page order should be randomized like we do for the production users page?

@davidbarsky
Copy link

This looks great! I think the randomization would be a good addition.

@skade
Copy link
Contributor

skade commented Nov 14, 2019

I have a concern here: are we free to translate those texts or do any of the sponsors feel like they must approve translations? Or am I overthinking this?

@pietroalbini
Copy link
Member

Mozilla is also providing a dedicated server for perf btw.

@davidbarsky
Copy link

At least from AWS' side, I think y'all should be free to translate those texts without AWS' approval. It's a decently small blurb, and so long the intent is carried over, then I don't think there will be any issue.

@rylev
Copy link
Member

rylev commented Nov 14, 2019

I'm triple checking with marketing about this, but it looks great to me. I don't believe there are any issues that would require approval of translations.

@skade
Copy link
Contributor

skade commented Nov 14, 2019

Thanks @davidbarsky and @rylev!

@rylev
Copy link
Member

rylev commented Nov 18, 2019

This should be fine from our end! Thanks for the shout out!

@skade
Copy link
Contributor

skade commented Nov 20, 2019

Merging this to staging, please wait for sign-off from @nikomatsakis

@skade skade merged commit e770231 into rust-lang:master Nov 20, 2019
@carols10cents carols10cents deleted the sponsors branch December 4, 2019 18:28
@nikomatsakis
Copy link

Just to be clear, I did sign off (cc @skade)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants