-
Notifications
You must be signed in to change notification settings - Fork 298
Add sponsors page #951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sponsors page #951
Conversation
I think the approach of putting a thanks on the homepage is a very clever one, thanks! I'll review later to get it out of the door. |
cc @davidbarsky for the AWS side. By the way, maybe the page order should be randomized like we do for the production users page? |
This looks great! I think the randomization would be a good addition. |
I have a concern here: are we free to translate those texts or do any of the sponsors feel like they must approve translations? Or am I overthinking this? |
Mozilla is also providing a dedicated server for perf btw. |
At least from AWS' side, I think y'all should be free to translate those texts without AWS' approval. It's a decently small blurb, and so long the intent is carried over, then I don't think there will be any issue. |
I'm triple checking with marketing about this, but it looks great to me. I don't believe there are any issues that would require approval of translations. |
Thanks @davidbarsky and @rylev! |
This should be fine from our end! Thanks for the shout out! |
Merging this to staging, please wait for sign-off from @nikomatsakis |
Just to be clear, I did sign off (cc @skade) |
This adds a section to the bottom of the homepage for thanks in general, with links to thanks.rust-lang.org and a new sponsors page:
The new sponsors page thanks Microsoft, AWS, and Mozilla for their infrastructure sponsorships (in 2 screenshots, there isn't actually a blank spot on the page between Microsoft and AWS):
I took most of the text from the 1.37.0 release announcement.
Before merging this, I would like review on the text and logo inclusion from:
I'm happy to make any modifications; let me know what needs to change. Thanks!