-
Notifications
You must be signed in to change notification settings - Fork 303
Align Items on WASM Getting Started Page #649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I would like to see the text aligned as well but I haven't had any success with using the baseline attributes |
I think this SO answer might help: https://stackoverflow.com/a/39197187/273503. This is a bit of a limitation with Flexbox as far as I know, I think this would be fairly easy with CSS Grids (though I really have no idea). |
Many thanks @sondr3! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think if we can increase the image-size slightly this should be good to merge!
Thank you for your patience everyone! Let me know what you think :) |
@Coder206 Hmm, this is what it currently looks like on my machine: NewOldI feel this might not be what you were going for with this PR? |
Agreed, just to be clear, are we looking to have the images vertically aligned, the first line of the text and the buttons at the same time? |
@Coder206 definitely the top of the images and the buttons. I'm less sure about the text -- so probably? Aligning text might require resizing images, which might take some effort. But if it's possible, perhaps it's worth a shot? |
I think making sure that the images are all the same size is the way to go. @Coder206, is that a change you can do? |
@skade I want to make sure I understand, you want me to make the widths of the images the same? |
@Coder206 They should all fit the same box (same height and width), which might need some resizing of the images. |
Accidentally fixed by skeleton removal, #830 is a followup. Thanks for the PR and the work, even if it didn't end up being merged. |
Fixes #604
Before:

After:

Inspired by: #623