Skip to content

Align Items on WASM Getting Started Page #649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

Coder206
Copy link
Contributor

@Coder206 Coder206 commented Dec 14, 2018

Fixes #604

Before:
screenshot_2018-12-14 wasm - rust programming language 1

After:
screenshot_2018-12-14 wasm - rust programming language

Inspired by: #623

@Coder206
Copy link
Contributor Author

I would like to see the text aligned as well but I haven't had any success with using the baseline attributes

@sondr3
Copy link

sondr3 commented Dec 15, 2018

I think this SO answer might help: https://stackoverflow.com/a/39197187/273503. This is a bit of a limitation with Flexbox as far as I know, I think this would be fairly easy with CSS Grids (though I really have no idea).

@Coder206
Copy link
Contributor Author

Many thanks @sondr3!

@ghost
Copy link

ghost commented Dec 19, 2018

I think the images should become bigger again as well:
grafik
They are smaller than before.

Copy link
Member

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if we can increase the image-size slightly this should be good to merge!

@Coder206
Copy link
Contributor Author

Thank you for your patience everyone! Let me know what you think :)

@yoshuawuyts
Copy link
Member

@Coder206 Hmm, this is what it currently looks like on my machine:

New

2019-01-18-174415_3840x2160

Old

2019-01-18-174441_3840x2160

I feel this might not be what you were going for with this PR?

@Coder206
Copy link
Contributor Author

Agreed, just to be clear, are we looking to have the images vertically aligned, the first line of the text and the buttons at the same time?

@yoshuawuyts
Copy link
Member

Agreed, just to be clear, are we looking to have the images vertically aligned, the first line of the text and the buttons at the same time?

@Coder206 definitely the top of the images and the buttons. I'm less sure about the text -- so probably?

Aligning text might require resizing images, which might take some effort. But if it's possible, perhaps it's worth a shot?

@skade
Copy link
Contributor

skade commented May 9, 2019

I think making sure that the images are all the same size is the way to go. @Coder206, is that a change you can do?

@Coder206
Copy link
Contributor Author

@skade I want to make sure I understand, you want me to make the widths of the images the same?

@skade
Copy link
Contributor

skade commented May 16, 2019

@Coder206 They should all fit the same box (same height and width), which might need some resizing of the images.

@skade
Copy link
Contributor

skade commented May 29, 2019

Accidentally fixed by skeleton removal, #830 is a followup.

Thanks for the PR and the work, even if it didn't end up being merged.

@skade skade closed this May 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Getting started Items of the WASM Page are misaligned
4 participants