Skip to content

fix(cleanup): home page #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 29, 2018
Merged

fix(cleanup): home page #128

merged 7 commits into from
Oct 29, 2018

Conversation

ashleygwilliams
Copy link
Member

@ashleygwilliams ashleygwilliams commented Oct 29, 2018

fixes #121, #122

this PR standardizes the highlight colors, as well as link and button styles per color panel profile. it standardizes the calls to action on the homepage, and sets up the CSS to do the same on other pages, which i will handle in subsequent PRs.

@ashleygwilliams
Copy link
Member Author

screen shot 2018-10-29 at 2 25 22 pm

@ashleygwilliams
Copy link
Member Author

screen shot 2018-10-29 at 2 43 30 pm

@ashleygwilliams
Copy link
Member Author

@aturon i removed the tilde quote. to be honest i just really didn't find it compelling and it was taking up way too much space in my opinion. still not sure i love that button but it's more discoverable the way it is now. text-size on it looks small but is the same as the other calls to action.

@ashleygwilliams
Copy link
Member Author

not sure i love the yellow. green highlight color might be better on the white and looks a little less 90s website under construction.

@ashleygwilliams
Copy link
Member Author

bumped text size here to subtitle size and i think it looks a lot better. made the quote body font not header font and smaller. looks more professional to me. let me know your thoughts.

@ashleygwilliams
Copy link
Member Author

@aidanhs do we have permissions from the companies listed here to link? if so i will link these to the company pages. ideally we can collect blogposts from each on their rust usage and link to those instead.

@ashleygwilliams
Copy link
Member Author

@ashleygwilliams
Copy link
Member Author

screen shot 2018-10-29 at 2 54 43 pm

not attached to this styling maybe we want to do a highlight instead of a underline (will look more profesh imo)

@ashleygwilliams ashleygwilliams changed the title [WIP] fix(cleanup): several things [WIP] fix(cleanup): home page Oct 29, 2018
@ashleygwilliams
Copy link
Member Author

screen shot 2018-10-29 at 4 44 36 pm

the pages that these link to need to exist

@ashleygwilliams
Copy link
Member Author

screenshot_2018-10-29 rust - index

final look, merging now

@ashleygwilliams
Copy link
Member Author

actually i think the header looks tight. i'm gonna broaden it. also take my own stab at the marketing line because i dont really like the repetition of word rust in this one.

@ashleygwilliams
Copy link
Member Author

ashleygwilliams commented Oct 29, 2018

screen shot 2018-10-29 at 5 47 49 pm

@ashleygwilliams ashleygwilliams changed the title [WIP] fix(cleanup): home page fix(cleanup): home page Oct 29, 2018
@ashleygwilliams ashleygwilliams added this to the Content: Stage 3 milestone Oct 29, 2018
@ashleygwilliams
Copy link
Member Author

merging so i can keep going with the css refactor throughout other pages. would still like feedback from @aturon here

@ashleygwilliams ashleygwilliams merged commit 1212030 into master Oct 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review color scheme
1 participant