Switch review labels for users with write perm when requesting changes #2211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kobzol
approved these changes
Oct 29, 2025
|
|
||
| #[derive(Debug, serde::Deserialize)] | ||
| pub struct CollaboratorPermission { | ||
| pub permission: String, |
Member
There was a problem hiding this comment.
We could use an enum here to make it a bit nicer to deal with.
Member
Author
There was a problem hiding this comment.
I also wanted use an enum but GitHub's own documentation/schema says it's just a string, but on the other hand they say it can only be admin, write, read, and none. Unsure what to do.
Member
There was a problem hiding this comment.
Let's leave it. If we use the collaborator permissions on more places, then we can refactor it.
Contributor
|
Thank you for working on this ❤️ I can't wait to leave some reviews |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts the
[review-submitted]issue handler to also switch review labels for users with write permission when requesting changes.Fixes #2169
cc @tgross35