Skip to content

Conversation

@Urgau
Copy link
Member

@Urgau Urgau commented Oct 24, 2025

@Urgau Urgau requested a review from Kobzol October 24, 2025 20:01
@Urgau
Copy link
Member Author

Urgau commented Oct 24, 2025

We really should have tests for the Zulip parsing, like we do for GitHub commands, it's way too easy to break the parsing.

We should probably move all the parsing of the Zulip commands in our parser crate and add the tests their. Maybe even re-use some of the parsing facilities we have for the GitHub commands.

Copy link
Member

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol, I thought you copy-pasted it, totally missed that 🤦

View changes since this review

@Urgau
Copy link
Member Author

Urgau commented Oct 24, 2025

Lol, I thought you copy-pasted it, totally missed that 🤦

Well, I did that, but had to modify the logic around the position and missed that the cmd_index + 1 was necessary, totally on my side.

@Urgau Urgau added this pull request to the merge queue Oct 24, 2025
Merged via the queue into rust-lang:master with commit 1340bf1 Oct 24, 2025
3 checks passed
@Urgau Urgau deleted the zulip-cmd-skip-one branch October 24, 2025 20:47
@Urgau
Copy link
Member Author

Urgau commented Oct 24, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants