Skip to content

Remove our custom diff parsing and prefer Github compare json API #2006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Urgau
Copy link
Member

@Urgau Urgau commented May 22, 2025

Follow-up to #2005, only the last commit is relevant.

@Urgau Urgau requested a review from Kobzol May 22, 2025 19:38
@Urgau Urgau force-pushed the remove-custom-diff branch from 43d6551 to 7149430 Compare May 23, 2025 15:44
@Urgau Urgau marked this pull request as ready for review May 23, 2025 15:44
@rustbot
Copy link
Collaborator

rustbot commented May 23, 2025

⚠️ Warning ⚠️

  • Some commits in this PR modify submodules.

@Urgau Urgau force-pushed the remove-custom-diff branch from 7149430 to 205897c Compare May 23, 2025 15:46
@Urgau
Copy link
Member Author

Urgau commented May 23, 2025

  • Some commits in this PR modify submodules.

This is really weird, we don't have any submodules in this repository. For some reason my commit probably has two parents, maybe the rebase was weird, idk

btw, this is read for review @Kobzol

@Urgau
Copy link
Member Author

Urgau commented May 23, 2025

Oh, this is funny, our modified submodules handler is looking at the PR diff for "Subproject commit" in it and warns if it finds one, which of course there are, bc I'm modifying the handler tests. 😄

let re = regex::Regex::new(r"\+Subproject\scommit\s").unwrap();
if diff.iter().any(|fd| re.is_match(&fd.diff)) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants