Skip to content

Conversation

@Urgau
Copy link
Member

@Urgau Urgau commented Feb 11, 2025

Instead of locking the MCP GitHub issue, like was done in #1876 (until a subsequent revert), I think we should put more emphasis on the Zulip thread in MCP opening comment.

Currently it's kind of hidden between a wall of text, I propose that we use GitHub blockquote annotations to increase the emphasis on it. I also included some minor stylistic changes to help break the wall of text.

I choose "Important" as I feel like it's the only one that fits our goal.

cc @apiraino
r? @ehuss

@Urgau
Copy link
Member Author

Urgau commented Feb 11, 2025

Important

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

Concerns or objections to the proposal should be discussed on Zulip and formally registered here by adding a comment.

@rfcbot concern reason-for-concern 
<description of the concern> 

Concerns can be lifted with:

@rfcbot resolve reason-for-concern 

See documentation at https://forge.rust-lang.org

cc @rust-lang/compiler

@ehuss
Copy link
Contributor

ehuss commented Feb 13, 2025

@apiraino Are you OK with this?

@apiraino
Copy link
Contributor

apiraino commented Feb 13, 2025

¯\(ツ)

My opinion is that people not reading comments will keep not reading comments. Any sort of emphasis we add after a while is not noticed anymore. Maybe these comments come because some people reply to a notification? Who knows.

In any case, I don't think this is such a pressing or extremely annoying problem worth our time.

Let's merge and move on.

@ehuss ehuss enabled auto-merge February 13, 2025 21:31
Copy link
Contributor

@ehuss ehuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ehuss ehuss merged commit d458d7a into rust-lang:master Feb 13, 2025
2 checks passed
@apiraino
Copy link
Contributor

@Urgau the MCP template is now a little bit hostile 😅 the same warning is now in CAPS and in blockquote.
https://togithub.com/rust-lang/compiler-team/issues/836#issuecomment-2659236468

Do you think we can remove the warning from the MCP template and just use yours (whichI think is more visible)?

@apiraino
Copy link
Contributor

alternative we can add also a

<blink>This issue is not meant to be used for technical discussion</blink>

:D

Urgau added a commit to Urgau/compiler-team that referenced this pull request Feb 14, 2025
It is replaced by rustbot important message which does the same thing in a more visible and *hopefully* more effective manner, cf. rust-lang/triagebot#1902
@Urgau
Copy link
Member Author

Urgau commented Feb 14, 2025

Do you think we can remove the warning from the MCP template and just use yours (whichI think is more visible)?

Yeah, sure, good idea.

It will even clear some vertical space.

Done in rust-lang/compiler-team#837

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants