-
Notifications
You must be signed in to change notification settings - Fork 96
Emphasis Zulip thread more in MCP opening comment #1902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed. Concerns or objections to the proposal should be discussed on Zulip and formally registered here by adding a comment. Concerns can be lifted with: See documentation at https://forge.rust-lang.org cc |
|
@apiraino Are you OK with this? |
|
¯\(ツ)/¯ My opinion is that people not reading comments will keep not reading comments. Any sort of emphasis we add after a while is not noticed anymore. Maybe these comments come because some people reply to a notification? Who knows. In any case, I don't think this is such a pressing or extremely annoying problem worth our time. Let's merge and move on. |
ehuss
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
@Urgau the MCP template is now a little bit hostile 😅 the same warning is now in CAPS and in blockquote. Do you think we can remove the warning from the MCP template and just use yours (whichI think is more visible)? |
|
alternative we can add also a
:D |
It is replaced by rustbot important message which does the same thing in a more visible and *hopefully* more effective manner, cf. rust-lang/triagebot#1902
Yeah, sure, good idea. It will even clear some vertical space. Done in rust-lang/compiler-team#837 |
Instead of locking the MCP GitHub issue, like was done in #1876 (until a subsequent revert), I think we should put more emphasis on the Zulip thread in MCP opening comment.
Currently it's kind of hidden between a wall of text, I propose that we use GitHub blockquote annotations to increase the emphasis on it. I also included some minor stylistic changes to help break the wall of text.
I choose "Important" as I feel like it's the only one that fits our goal.
cc @apiraino
r? @ehuss