Invalid assignee fallback sometimes doesn't kick in?

[jieyouxu]

See rust-lang/rust#141469 (comment):

• Veykril (looking at rust-lang/team) is r-a team member, and r-a has bors.rust.review = true, so they should have r+ (https://github.com/rust-lang/team/blob/c7359dee2601984c88318efc83a15f5f788d241e/teams/rust-analyzer.toml#L27-L28)?
• For whatever reason they cannot be assigned directly via r? @Veykril.
• But then no fallback reviewer was assigned.

I wonder if there are two issues at play here:

1. Cannot be assigned might be because rust-analyzer does not have at least "write" access to rust-lang/rust (https://github.com/rust-lang/team/blob/c7359dee2601984c88318efc83a15f5f788d241e/repos/rust-lang/rust.toml#L7-L27)
2. No fallback reviewer assignment I assume is a different issue?

[jieyouxu]

as Veykril work show says

rust-lang/rust PRs in your review queue: (0 PRs)
Review capacity: Not set (i.e. unlimited)

Rotation mode: on rotation

Note that only certain PRs that are assigned to you are included in your review queue.

so they're not on vacation or have insufficient review capacity.

[jieyouxu]

For (1), it does seem like r-a doesn't have write accecss to r-l/r even if they have r+: rust-lang/team#1841

EDIT: that is fixed

[Kobzol]

as Veykril work show says

rust-lang/rust PRs in your review queue: (0 PRs)
Review capacity: Not set (i.e. unlimited)

Rotation mode: on rotation

Note that only certain PRs that are assigned to you are included in your review queue.

so they're not on vacation or have insufficient review capacity.

Note that triagebot doesn't yet take the output of work show into account, so this should not be relevant here.

[jieyouxu]

Looks like it's the lack-of-write-access, e.g. after write perms were granted, r-a team members can be assigned now (e.g. rust-lang/rust#141585).