Skip to content

Backport rust-cookbook repo #1800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Apr 30, 2025

Backporting the following repos:

  • rust-cookbook

    Original content
    org = "rust-lang-nursery"
    name = "rust-cookbook"
    description = "https://rust-lang-nursery.github.io/rust-cookbook"
    bots = []
    
    [access.teams]
    
    [access.individuals]
    erickt = "admin"
    marcoieni = "admin"
    trentspi = "write"
    steveklabnik = "admin"
    carols10cents = "admin"
    nrc = "admin"
    nikomatsakis-admin = "admin"
    AndyGauge = "write"
    nikomatsakis = "admin"
    aidanhs = "admin"
    rust-lang-owner = "admin"
    budziq = "write"
    jdno = "admin"
    Mark-Simulacrum = "admin"
    aturon = "admin"
    branderson = "write"
    sfackler = "admin"
    dtolnay = "admin"
    pietroalbini = "admin"
    huonw = "admin"
    KodrAus = "admin"
    kennytm = "admin"
    dhharris = "write"
    alexcrichton = "admin"

I'm not sure what to do about this one. It's active, but it's being managed by user(s) outside existing teams, @AndyGauge.

Copy link

github-actions bot commented Apr 30, 2025

Dry-run check results

[WARN  sync_team] sync-team is running in dry mode, no changes will be applied.
[INFO  sync_team] synchronizing github
[INFO  sync_team] 💻 Team Diffs:
    📝 Editing team 'rust-lang/all':
      Adding member 'AndyGauge' with member role
    ➕ Creating team:
      Org: rust-lang-nursery
      Name: cookbook
      Description: Managed by the rust-lang/team repository.
      Privacy: closed
      Members:
        AndyGauge: member
    📝 Editing team 'rust-lang/inside-rust-reviewers':
      Adding member 'AndyGauge' with member role
    ➕ Creating team:
      Org: rust-lang-nursery
      Name: lang-docs
      Description: Managed by the rust-lang/team repository.
      Privacy: closed
      Members:
        Gankra: member
        Havvy: member
        JohnTitor: member
        ehuss: member
        matthewjasper: member
        traviscross: member
    📝 Editing team 'rust-lang/leads':
      Adding member 'AndyGauge' with member role
    💻 Repo Diffs:
    📝 Editing repo 'rust-lang-nursery/rust-cookbook':
      Remove homepage: ''
      Enable auto-merge
      Permission Changes:
        Giving team 'lang-docs' write permission
        Giving team 'cookbook' write permission
        Removing user 'dtolnay''s admin permission 
        Removing user 'AndyGauge''s write permission 
        Removing user 'dhharris''s write permission 
        Removing user 'alexcrichton''s admin permission 
        Removing user 'budziq''s write permission 
        Removing user 'branderson''s write permission 
        Removing user 'trentspi''s write permission 

@AndyGauge
Copy link

Thanks for the heads up

@Kobzol
Copy link
Contributor Author

Kobzol commented May 1, 2025

Do you have a suggestion on what team(s) should have access here? Maybe we should create a new team, similar to https://github.com/rust-lang/team/blob/master/teams/rustlings.toml?

@Kobzol Kobzol marked this pull request as ready for review June 3, 2025 06:15
@Kobzol
Copy link
Contributor Author

Kobzol commented Jun 3, 2025

I created a cookbook team and assigned it to the repository.

@traviscross
Copy link
Contributor

@Kobzol: I've created a PR on your PR:

Kobzol#5

@ehuss and I talked about this today on the lang-docs call, and with that change, we agree this will be OK to merge. Even if we might want to make later changes here, it's better to get this under management first.

@Kobzol
Copy link
Contributor Author

Kobzol commented Jun 4, 2025

Ok, changed! Btw on the rustlings repo, which is also a repo managed by a subteam of lang-docs, the lang-docs team doesn't have access.

@traviscross
Copy link
Contributor

traviscross commented Jun 4, 2025

Thanks. With the update, this looks OK to me. It looked OK to @ehuss as well, inclusive of the update, when we discussed on Tuesday. This is OK to merge.

cc @rust-lang/team-repo-admins

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants