Skip to content

Run rustfmt on stable, delete rustfmt.toml #619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 13, 2018
Merged

Run rustfmt on stable, delete rustfmt.toml #619

merged 1 commit into from
Dec 13, 2018

Conversation

alexcrichton
Copy link
Member

This commit switches CI to running rustfmt on the stable compiler (as
rustfmt is stable now!). Additionally it deletes rustfmt.toml to
ensure we're following the same style as the rest of the ecosystem.

@alexcrichton
Run rustfmt on stable, delete rustfmt.toml
1851cd1 
This commit switches CI to running `rustfmt` on the stable compiler (as
rustfmt is stable now!). Additionally it deletes `rustfmt.toml` to
ensure we're following the same style as the rest of the ecosystem.
gnzlbg
gnzlbg approved these changes Dec 13, 2018
View reviewed changes
Copy link
Contributor

@gnzlbg gnzlbg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I don't mind much about the formatting style. The only thing I notice with the new formatting is that there is a little bit more line-wrapping when reviewing PRs side-by-side, but as long as it's not too much its not really a big deal.

@alexcrichton alexcrichton merged commit d49025c into rust-lang:master Dec 13, 2018
@alexcrichton alexcrichton deleted the rustfmt branch December 13, 2018 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnzlbg gnzlbg gnzlbg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexcrichton @gnzlbg