Start adding some avx512 intrinsics #618
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was actually quite surprised to learn but my local computer has avx512f at least, so I was even able to run and execute these tests! |
alexcrichton
commented
Dec 13, 2018
| @@ -391,6 +391,10 @@ types! { | |||
| pub struct __m512d(f64, f64, f64, f64, f64, f64, f64, f64); | |||
| } | |||
|
|
|||
| /// The `__mmask16` type used in AVX-512 intrinsics, a 16-bit integer | |||
| #[allow(non_camel_case_types)] | |||
| pub type __mmask16 = i16; | |||
There was a problem hiding this comment.
FWIW this is definitely something we're going to want to debate/decide before stabilization. I've never used this type before (or these intrinsics) so this is the most naive way to translate it, but other options include:
- A newtype struct wrapper
- An unsigned number
I'm not sure what the best option is, but others I'm sure to!
First one is the quite simple `_mm512_abs_epi32` intrinsic!
gnzlbg
approved these changes
Dec 14, 2018
gnzlbg
reviewed
Dec 14, 2018
| @@ -10,7 +10,9 @@ exclude = [ | |||
| [profile.release] | |||
| debug = true | |||
| opt-level = 3 | |||
| incremental = true | |||
There was a problem hiding this comment.
Oh it wasn't needed per se, but it made development a lot easier as it doesn't regress any codegen and it makes release builds (assert_instr) much faster
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First one is the quite simple
_mm512_abs_epi32intrinsic!