Enable IP_BOUND_IF on illumos and Solaris
#561
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `IP_BOUND_IF` socket option, which is wrapped by the
`Socket::bind_device_by_index_{v4,v6}` and
`Socket::device_index_{v4,v6}` is available on SunOS-like systems, such
as illumos and Solaris, as well as macOS-like systems. However, these
APIs are currently cfg-flagged to only be available on macOS-like
systems.
This commit changes the cfg attributes to also enable these APIs on
illumos and Solaris.
Fixes rust-lang#560
hawkw
force-pushed
the
eliza/bind_if_on_illumos
branch
from
2928673 to
51e9773
Compare
|
Ugh, it looks like |
hawkw
commented
Feb 27, 2025
`libc` [v0.2.171] was just released, and it includes definitions of `IP_BOUND_IF` for Solarish operating systems. Thus, we can now remove the temporary local definitions. [v0.2.171]: https://github.com/rust-lang/libc/releases/tag/0.2.171
Thomasdezeeuw
approved these changes
Mar 11, 2025
|
Thanks @hawkw |
|
@Thomasdezeeuw would it be possible to get a patch release of |
7 tasks
|
@hawkw yes, if you can create a pr to target 0.5.x that would be helpful 👍 |
hawkw
added a commit
to hawkw/socket2-rs
that referenced
this pull request
Mar 17, 2025
The `IP_BOUND_IF` socket option, which is wrapped by the
`Socket::bind_device_by_index_{v4,v6}` and
`Socket::device_index_{v4,v6}` is available on SunOS-like systems, such
as illumos and Solaris, as well as macOS-like systems. However, these
APIs are currently cfg-flagged to only be available on macOS-like
systems.
This commit changes the cfg attributes to also enable these APIs on
illumos and Solaris.
Fixes rust-lang#560
Thomasdezeeuw
pushed a commit
that referenced
this pull request
Mar 20, 2025
The `IP_BOUND_IF` socket option, which is wrapped by the
`Socket::bind_device_by_index_{v4,v6}` and
`Socket::device_index_{v4,v6}` is available on SunOS-like systems, such
as illumos and Solaris, as well as macOS-like systems. However, these
APIs are currently cfg-flagged to only be available on macOS-like
systems.
This commit changes the cfg attributes to also enable these APIs on
illumos and Solaris.
Fixes #560
hawkw
added a commit
to hawkw/reqwest
that referenced
this pull request
Mar 31, 2025
The `ClientBuilder` type has an `interface` method that sets the name of a specific network interface to bind TCP connections on. This method is currently only enabled on Linux, Android, and Fuchsia, as it uses the `SO_BINDTODEVICE` socket option, which only exists on those systems. Upstream changes to `socket2` (rust-lang/socket2#561) and `hyper-util` (hyperium/hyper-util#176) have added support for similar functionality on macOS (and other Apple operating systems, such as iOS, watchOS, tvOS, and visionOS), and Solaris and Solaris-like systems like illumos, using the `IP_BOUND_IF`/`IPV6_BOUND_IF` socket options on those systems. This branch enables the `ClientBuilder::interface` API on these additional target OSes. Note that this presently requires a Cargo patch to take a Git dependency on hyperium/hyper-util@5831ace. Once that commit is published, the patch can be removed. This PR should not be merged until then. Fixes seanmonstar#2571
seanmonstar
pushed a commit
to seanmonstar/reqwest
that referenced
this pull request
Apr 9, 2025
The `ClientBuilder` type has an `interface` method that sets the name of a specific network interface to bind TCP connections on. This method is currently only enabled on Linux, Android, and Fuchsia, as it uses the `SO_BINDTODEVICE` socket option, which only exists on those systems. Upstream changes to `socket2` (rust-lang/socket2#561) and `hyper-util` (hyperium/hyper-util#176) have added support for similar functionality on macOS (and other Apple operating systems, such as iOS, watchOS, tvOS, and visionOS), and Solaris and Solaris-like systems like illumos, using the `IP_BOUND_IF`/`IPV6_BOUND_IF` socket options on those systems. This branch enables the `ClientBuilder::interface` API on these additional target OSes. Fixes #2571
Hasan6979
pushed a commit
to NordSecurity/socket2
that referenced
this pull request
May 15, 2025
The `IP_BOUND_IF` socket option, which is wrapped by the
`Socket::bind_device_by_index_{v4,v6}` and
`Socket::device_index_{v4,v6}` is available on SunOS-like systems, such
as illumos and Solaris, as well as macOS-like systems. However, these
APIs are currently cfg-flagged to only be available on macOS-like
systems.
This commit changes the cfg attributes to also enable these APIs on
illumos and Solaris.
Fixes rust-lang#560
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
IP_BOUND_IFsocket option, which is wrapped by theSocket::bind_device_by_index_{v4,v6}andSocket::device_index_{v4,v6}is available on SunOS-like systems, suchas illumos and Solaris, as well as macOS-like systems. However, these
APIs are currently cfg-flagged to only be available on macOS-like
systems.
This commit changes the cfg attributes to also enable these APIs on
illumos and Solaris.
Fixes #560