Repository navigation
feat(errors): suggest another toolchain on component removal - #5130
Merged
rami3l merged 2 commits intoOct 7, 2026
Merged
Conversation
rami3l
approved these changes
Oct 7, 2026
Member
|
PS: I've changed your PR description so it no longer closes #5098 since it's not a full solution. I'll link this PR in the issue description afterwards. |
Contributor
Author
|
Thanks so much for the review and the merge, rami3l! Splitting the panic fix out into its own PR was spot on, and it made this change much easier to reason about. Mirroring the target hint from #5094 taught me a lot about how rustup shapes its error suggestions, and it was genuinely fun to work on. Thanks also for fixing the description so #5098 stays open for the rest of the work 🦀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially addresses: #5098
rustup component remove <component>now suggests another installed toolchain when the component isn't available in the current one. If no other toolchain has the component, the existing error is unchanged.Same shape as #5094 for targets. The
component addcase is left for a follow-up.