-
Notifications
You must be signed in to change notification settings - Fork 987
feat(toolchain): consider external rust-analyzer when calling a proxy
#4324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6fa6a79 to
9fd24ff
Compare
19cc68b to
15569c1
Compare
15569c1 to
a45dd3f
Compare
weihanglo
reviewed
May 8, 2025
weihanglo
reviewed
May 8, 2025
a45dd3f to
a3330ad
Compare
djc
reviewed
May 9, 2025
542b5bf to
389474d
Compare
djc
approved these changes
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3846.
Following the reasoning in #3846 (comment), this PR make rustup prioritize rustup-hosted RA and only delegates to the outside as a final rescue. This way, it will also close #3299:
This approach has also been approved by @davidbarsky in #t-rustup > More frequent rust-analyzer updates in rustup @ 💬 as a temporary measure before the new update cadence for RA on our release server is settled.
Concerns
Should we emit a log line indicating the fallback is happening? Idem for the pre-existingAdded.cargofallback.