Tidy up the mock dist server #1998
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I believe the failing Windows test also fails on |
Contributor
Travis' Windows testing is still in beta (and we'll probably drop it) so I don't predicate merging on that passing so long as appveyor is good. |
Contributor
|
☔ The latest upstream changes (presumably #1997) made this pull request unmergeable. Please resolve the merge conflicts. |
jonhoo
force-pushed
the
tidy-dist-mock
branch
from
55bd89d to
b406392
Compare
jonhoo
force-pushed
the
tidy-dist-mock
branch
from
b406392 to
4e8bcf5
Compare
kinnison
approved these changes
Sep 17, 2019
Contributor
kinnison
left a comment
kinnison
left a comment
There was a problem hiding this comment.
This is very nice. I particularly like the proper Release struct with its associated methods.
Thank you. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is follow-on clean-up work from #1997 which tidies up
tests::mock::clitools::create_mock_dist_serverso that it is much clearer which versions are available with each "Scenario". I will mark this as ready to review and rebase once #1997 lands.