Using clippy from a rustup linked toolchain doesn't work.

[vext01]

Originally discussed here.

Running cargo clippy when the project's toolchain has been overridden to a linked rustup toolchain doesn't work.

$ cargo clippy
error: 'cargo-clippy' is not installed for the toolchain 'yk-stage1'
To install, run `rustup component add clippy --toolchain yk-stage1`
$ rustup toolchain list -v
nightly-x86_64-unknown-linux-gnu (default)      /home/vext01/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu                                              
yk-stage1 (override)    /home/vext01/research/yorick/ykrustc/build/x86_64-unknown-linux-gnu/stage1                                                            

But running the tool manually with a library path set does work:

LD_LIBRARY_PATH=/home/vext01/research/yorick/ykrustc/build/x86_64-unknown-linux-gnu/stage1/lib/rustlib/x86_64-unknown-linux-gnu/lib \
    /home/vext01/research/yorick/ykrustc/build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/release/cargo-clippy

[jyn514]

@vext01 I would expect this to be an x.py bug and not a rustup bug. Notice how the path with clippy is in stage1-tools, not stage1.

[jyn514]

See also rust-lang/rust#78717 and rust-lang/rust#76666.

[vext01]

I see. So shall we close this?

[vext01]

But wait.

To be clear, the error comes from running cargo clippy in a normal rust project (not the compiler) where the toolchain has been overridden. I don't think x.py is involved, is it?

[jyn514]

x.py needs to build clippy and put it in stage1/bin before rustup can use it. stage1-tools does not have a full toolchain.

[vext01]

Ah yes, gotcha. It's building a clippy, but I guess it aint in the right place :)

[kinnison]

I don't think this is an issue for rustup, so I'll close it. If I've misunderstood, please ping me and I'll reopen it.