Colors are broken on MSYS2 shell.

[jamen]

Problem

Colors are broken in VSCode terminal with MSYS2 shell. For example, rustup show outputs this:

But, Cargo's colors work fine:

So this isn't an issue on my end afaik.

Steps

1. Use Windows, MSYS2, and VSCode terminal
2. Use the MSYS2 shell with

    "terminal.integrated.shell.windows": "C:\\msys64\\msys2_shell.cmd",
    "terminal.integrated.shellArgs.windows": [
        "-defterm",
        "-no-start",
        "-use-full-path",
        "-mingw",
        "-here"
    ],

3. Run a command which outputs color like rustup show

Possible Solution(s)

Copy how Cargo is doing colors.

Notes

• Output of rustup --version: rustup 1.21.1 (7832b2e 2019-12-20)
• Output of rustup show: See above.
• Output of echo $TERM: xterm-256color

[kinnison]

This is a problem with how we interact with the terminal using term -- I'd like to replace that with something better but right now we're a bit stuck.

This is related to #1835 #1818 and #1826

[aloucks]

Color is broken in all MSYS terminals, not just when using VSCode.

I thought that at one point color was just disabled, but now it shows garbled color codes:

[ForsakenHarmony]

I'm also running into this issue, fish from cygwin embedded in clion

The PR #2469 does not change the behaviour because in this case no env variable gets set

[aloucks]

I'm also running into this issue, fish from cygwin embedded in clion

The PR #2469 does not change the behaviour because in this case no env variable gets set

I think running rustup with winpty will also fix the issue.

[workingjubilee]

@rustbot label: +O-windows