-
Notifications
You must be signed in to change notification settings - Fork 34
Initial automated tier generation #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Looks great!
I can take care of this :) |
Not a single unknown target! 🤩 https://supercilex.github.io/rustup-components-history/ |
@JohnTitor bump |
The page looks great, thanks a lot! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally, I didn't have the energy to write a cron job, but someone should easily be able to run this in GH actions and do auto commits on a change to the config file.
It seems like this repo is already configured with a regular re-run, so getting this to work would be a matter of running the tool to generate configuration prior to running the tool that generates the website?
Essentially a one-line change here (https://github.com/rust-lang/rustup-components-history/blob/master/prepare-pages.sh#L14)
Am I missing something there?
Yeah, I guess that could work, but then the build isn't reproducible and will suffer potential reliability issues if the scraper breaks. I was thinking of running a separate config generator job that commits to master when a config change is detected. |
I'm not too worried about it breaking like that. We should dump the config to stdout as part of the build, I think that's enough. |
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
K, sounds good as long as you're aware of the downsides. |
@Mark-Simulacrum boop |
Thanks everybody! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summit
@JohnTitor Fixed once and for all! Closes #40.
The scraping code is a kinda shit, so sorry about that, but the idea is that we want to be able to easily change it. Also of course this is a terrible solution and both pages should be generated from a machine readable format, but I'm guessing it's easier for humans to edit the platform support markdown, so it's not too unreasonable to use that html as the "machine readable" format. Perhaps we can spruce up that page with some divs+ids around the markdown tables to make the scraper more robust.
Finally, I didn't have the energy to write a cron job, but someone should easily be able to run this in GH actions and do auto commits on a change to the config file.