Skip to content

Initial automated tier generation #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 24, 2023
Merged

Initial automated tier generation #49

merged 8 commits into from
Mar 24, 2023

Conversation

SUPERCILEX
Copy link
Contributor

@JohnTitor Fixed once and for all! Closes #40.

The scraping code is a kinda shit, so sorry about that, but the idea is that we want to be able to easily change it. Also of course this is a terrible solution and both pages should be generated from a machine readable format, but I'm guessing it's easier for humans to edit the platform support markdown, so it's not too unreasonable to use that html as the "machine readable" format. Perhaps we can spruce up that page with some divs+ids around the markdown tables to make the scraper more robust.

Finally, I didn't have the energy to write a cron job, but someone should easily be able to run this in GH actions and do auto commits on a change to the config file.

@JohnTitor
Copy link
Member

Looks great!
To check the content, could you deploy it on your GitHub Pages?
Also cc @mexus

Finally, I didn't have the energy to write a cron job, but someone should easily be able to run this in GH actions and do auto commits on a change to the config file.

I can take care of this :)

@SUPERCILEX
Copy link
Contributor Author

Not a single unknown target! 🤩 https://supercilex.github.io/rustup-components-history/

@SUPERCILEX
Copy link
Contributor Author

@JohnTitor bump

@JohnTitor
Copy link
Member

The page looks great, thanks a lot!
I don't have access to merge this PR, @Mark-Simulacrum could you take a look when you have time?

Copy link
Member

@Mark-Simulacrum Mark-Simulacrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally, I didn't have the energy to write a cron job, but someone should easily be able to run this in GH actions and do auto commits on a change to the config file.

It seems like this repo is already configured with a regular re-run, so getting this to work would be a matter of running the tool to generate configuration prior to running the tool that generates the website?

Essentially a one-line change here (https://github.com/rust-lang/rustup-components-history/blob/master/prepare-pages.sh#L14)

Am I missing something there?

@SUPERCILEX
Copy link
Contributor Author

Essentially a one-line change here

Yeah, I guess that could work, but then the build isn't reproducible and will suffer potential reliability issues if the scraper breaks. I was thinking of running a separate config generator job that commits to master when a config change is detected.

@Mark-Simulacrum
Copy link
Member

I'm not too worried about it breaking like that. We should dump the config to stdout as part of the build, I think that's enough.

Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
@SUPERCILEX
Copy link
Contributor Author

I'm not too worried about it breaking like that. We should dump the config to stdout as part of the build, I think that's enough.

K, sounds good as long as you're aware of the downsides.

@SUPERCILEX
Copy link
Contributor Author

@Mark-Simulacrum boop

@Mark-Simulacrum Mark-Simulacrum merged commit 84cd785 into rust-lang:master Mar 24, 2023
@SUPERCILEX
Copy link
Contributor Author

Thanks everybody!

Copy link

@Onceagain12 Onceagain12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants