Fix long type paths by breaking paths into multiple lines when exceeding maximum width#6494
Open
danielhuang wants to merge 2 commits intorust-lang:mainfrom
Open
Fix long type paths by breaking paths into multiple lines when exceeding maximum width#6494danielhuang wants to merge 2 commits intorust-lang:mainfrom
danielhuang wants to merge 2 commits intorust-lang:mainfrom
Conversation
danielhuang
force-pushed
the
fix-long-type-paths
branch
from
31ed77a to
352440c
Compare
Author
|
Does not fix #3863 (comment) yet. |
Contributor
|
I'm not sure how we should move forward here. I'm going to mark this one as blocked for now. If you could, please file an issue with team-style to see if they have any suggestions for defining rules on how to break long path names. |
ytmimi
added
the
S-blocked
jieyouxu
added
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A long type path could look like
long_type_path::long_type_path::long_type_path::long_type_path::long_type_path::long_type_path::long_type_path::long_type_path::long_type_path::long_type_path::Longwhich currently would not get formatted. This fix would break the path into multiple lines if necessary.