Backport #4572 - Proper indentation of multiline post-comments in a list #5649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… multiline post-comments in a list
ytmimi
reviewed
Jan 11, 2023
Comment on lines
+35
to
+37
| separator: &'a str, /* Comment */ | ||
| trailing_separator: SeparatorTactic, /* Comment */ | ||
| separator_place: SeparatorPlace, // Comment 1 |
There was a problem hiding this comment.
should these comments be aligned?
There was a problem hiding this comment.
The reason for the alignment of the one line comments is backward compatibility - see this #4546 comment. The workaround is actually applicable only to one line comments. However, assuming that one line comments are the common case, it should be applicable for most of the cases.
There was a problem hiding this comment.
Thanks for the link to the previous discussion!
ytmimi
reviewed
Jan 11, 2023
Comment on lines
+69
to
+70
| tactic: DefinitiveListTactic::Vertical, /* Comment */ | ||
| separator: ",", /* comment */ |
There was a problem hiding this comment.
Also, should these comments be aligned?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #4546
Backport #4572