Correct newline-style in json emitter #5418
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested fix for issue #4273 - using the configured
newline_style
for the emitted JSONexpected
parts. The PR is based on back-porting PR #4743 (that was not merged into R2).The approach taken is to propagate the newline-style setting by adding
emit_formatted_file_with_line_style()
function to the Emitter trait, and changing the defaultemit_formatted_file()
to call it. Allemit_formatted_file
implementation were changed toemit_formatted_file_with_line_style
, but the relevant code still callsemit_formatted_file
. This is except for theJsonEmitter
that callsemit_formatted_file_with_line_style
directly with the newline-style setting, and the function is using it for the emittedexpected
parts.Based on a comment to PR #4743, testings were added to
writemode
, to allow using test files.