Recognize when a block comment has been ended inside a string literal… #4796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for this, LGTM! Could you also do me a favor and add a file to cover another duplicate (#4806)? |
|
I added the case in #4806 to |
|
Thank you for adding the additional case! That's fine for now, but for future reference the preference is to either have file+issue specific pairs, or a separate file not named for any one issue if that file will contain cases from multiple issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back-porting the change in #4320 to branch
rustfmt-1.4.37.This would fix #4312 and its duplicate, #4744 .
Any suggestion is appreciated!