Skip to content

ensure idempotency on empty match blocks #4271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 22, 2020
Merged

ensure idempotency on empty match blocks #4271

merged 1 commit into from
Jun 22, 2020
+23 −5

Conversation

calebcartwright
Copy link
Member

Fixes #4267

topecongiro
topecongiro approved these changes Jun 22, 2020
View reviewed changes
Copy link
Contributor

@topecongiro topecongiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@topecongiro topecongiro merged commit e47881b into rust-lang:master Jun 22, 2020
@calebcartwright calebcartwright deleted the issue-4267 branch June 22, 2020 14:14
@calebcartwright calebcartwright restored the issue-4267 branch July 27, 2020 15:15
@calebcartwright calebcartwright deleted the issue-4267 branch July 27, 2020 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@topecongiro topecongiro topecongiro approved these changes

Assignees
No one assigned
Labels
backport-triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Formatting match with empty body is non-idempotent
3 participants
@calebcartwright @topecongiro @karyon