Skip to content

implement Display for enums with attribute config_type #3621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2019

Conversation

scampi
Copy link
Contributor

@scampi scampi commented Jun 12, 2019

Implementing Display was motivated by the default value of edition being Edition2015 although it should have been 2015. Also, it provides a to_string method which could be used in #3620.

Below are the differences this PR makes on the output of --help=config --unstable-features:

137c137
<                      edition [2015|2018] Default: Edition2015
---
>                      edition [2015|2018] Default: 2015
164c164
<             required_version <string> Default: "1.3.0" (unstable)
---
>             required_version <string> Default: 1.3.0 (unstable)
191c191
<                       ignore [<string>,..] Default: IgnoreList { path_set: {}, rustfmt_toml_path: "" } (unstable)
---
>                       ignore [<string>,..] Default: [] (unstable)

@topecongiro
Copy link
Contributor

Awesome, thank you!

@topecongiro topecongiro merged commit 04add0c into rust-lang:master Jun 12, 2019
@scampi scampi deleted the config-option-display branch June 12, 2019 19:17
@topecongiro topecongiro added this to the 1.3.1 milestone Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants