Expose methods to locate and load config #1613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Make method for searching parents for toml file public * Make method for loading config from path directly public, tweak the API since it was never returning None
topecongiro
reviewed
May 31, 2017
src/config.rs
Outdated
| /// Construct a `Config` from the toml file specified at `file_path`. | ||
| /// | ||
| /// This method only looks at the provided path, for a method that | ||
| /// searches parents for an `rls.toml` see `resolve_config`. |
There was a problem hiding this comment.
Is this line a typo, or only relevant when using from rls? If so, I would like to have it explained here since it may confusing afterward.
There was a problem hiding this comment.
Whoops, just a typo. Pushed a fix.
|
LGTM, thank you for cleaning up! Left a small nit inline, please take a look. |
nrc
approved these changes
May 31, 2017
src/config.rs
Outdated
| /// Construct a `Config` from the toml file specified at `file_path`. | ||
| /// | ||
| /// This method only looks at the provided path, for a method that | ||
| /// searches parents for an `rls.toml` see `resolve_config`. |
There was a problem hiding this comment.
I don't see resolve_config, I think the name is changed
There was a problem hiding this comment.
Oh boy, two typos in the same line. Pushed a fix, thanks.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API since it was never returning None
Would allow RLS to reuse the rustfmt.toml searching/loading code (rust-lang/rls#331)