Skip to content

Conversation

johannhof
Copy link
Contributor

This adds very simplistic instructions on how to run rustfmt on CI.

I also wrote a blog post for more details: http://johannh.me/blog/rustfmt-ci.html

## Checking style on a CI server

To keep your code base consistently formatted, it can be helpful to fail the CI build
when a pull request contains unformatted code. Using `--write-mode=diff` you can instruct
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the english here is a little confusing. Maybe something like " Using --write-mode=digg instructs Rustfmt to exit with an error code if the input is not formatted correctly. It will ..."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think I edited that sentence in a weird way. I'll fix it

This adds very simplistic instructions on how to run rustfmt on CI.

I also wrote a blog post for more details: http://johannh.me/blog/rustfmt-ci.html
@johannhof
Copy link
Contributor Author

@nrc updated, I also added a line about cargo: cache

@nrc nrc merged commit 59e199b into rust-lang:master Aug 25, 2016
@nrc
Copy link
Member

nrc commented Aug 25, 2016

Thanks for the PR!

@johannhof johannhof deleted the travis-docs branch August 25, 2016 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants