Add instructions on how to run rustfmt on Travis #1138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ## Checking style on a CI server | ||
|
|
||
| To keep your code base consistently formatted, it can be helpful to fail the CI build | ||
| when a pull request contains unformatted code. Using `--write-mode=diff` you can instruct |
There was a problem hiding this comment.
the english here is a little confusing. Maybe something like " Using --write-mode=digg instructs Rustfmt to exit with an error code if the input is not formatted correctly. It will ..."
There was a problem hiding this comment.
Yeah I think I edited that sentence in a weird way. I'll fix it
This adds very simplistic instructions on how to run rustfmt on CI. I also wrote a blog post for more details: http://johannh.me/blog/rustfmt-ci.html
|
@nrc updated, I also added a line about |
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds very simplistic instructions on how to run rustfmt on CI.
I also wrote a blog post for more details: http://johannh.me/blog/rustfmt-ci.html