Skip to content

Regression in formatting Syn's token macro #3331

Closed
@dtolnay

Description

@dtolnay

Our CI hit a surprising formatting change: https://travis-ci.org/dtolnay/syn/jobs/490139618.

 #[cfg(any(feature = "full", feature = "derive"))]
 pub fn fold_abi<V: Fold + ?Sized>(_visitor: &mut V, _i: Abi) -> Abi {
     Abi {
-        extern_token: Token![extern](tokens_helper(_visitor, &_i.extern_token.span)),
+        extern_token: Token ! [ extern ](tokens_helper(_visitor, &_i.extern_token.span)),
         name: (_i.name).map(|it| _visitor.fold_lit_str(it)),
     }
 }

I minimized this to:

echo 'Token ! [ extern ];' | cargo run --bin rustfmt

Before f4f9502:

Token![extern];

Since f4f9502:

Token ! [ extern ];

Mentioning @topecongiro and @scampi who were involved in that PR.

Metadata

Metadata

Assignees

No one assigned

    Labels

    a-macrosbugPanic, non-idempotency, invalid code, etc.p-high

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions